Make non-cmake installation instructions mimic cmake#319
Merged
jmigual merged 2 commits intosocketio:masterfrom Feb 25, 2022
Merged
Make non-cmake installation instructions mimic cmake#319jmigual merged 2 commits intosocketio:masterfrom
jmigual merged 2 commits intosocketio:masterfrom
Conversation
|
This definitely needs to be merged. I'm using Meson and this piece of information saved me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation instructions don't make it clear that certain preprocessor definitions have to be added in order to build successfully(#313) and that boost is not needed and its inclusion will still cause errors(#318, #300).
This change just copies the preprocessor definitions from the CMakeLists file to the installation instructions