Closed
Conversation
|
@darrachequesne this pr is available, do you want to merge it ? |
jmigual
requested changes
Mar 9, 2022
Comment on lines
+550
to
+554
| if (m_ping_timeout_timer) { | ||
| asio::error_code ec; | ||
| m_ping_timeout_timer->expires_from_now(milliseconds(m_ping_interval + m_ping_timeout),ec); | ||
| m_ping_timeout_timer->async_wait(std::bind(&client_impl::timeout_pong, this, std::placeholders::_1)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why are you recreating the timer here instead of just cancelling it?
There was a problem hiding this comment.
When the on_ping event is received, the timer needs to be reset. If the on_ping event is not received before the next timeout, it is considered that the local network is disconnected.
Comment on lines
+556
to
+560
| /*if(m_ping_timeout_timer) | ||
| { | ||
| m_ping_timeout_timer->cancel(); | ||
| m_ping_timeout_timer.reset(); | ||
| } | ||
| }*/ |
Collaborator
There was a problem hiding this comment.
Don't leave commented code. Just remove it.
Suggested change
| /*if(m_ping_timeout_timer) | |
| { | |
| m_ping_timeout_timer->cancel(); | |
| m_ping_timeout_timer.reset(); | |
| } | |
| }*/ |
Contributor
|
I have opened another pull request that also adresses this issue. |
Collaborator
|
Closing because #351 already fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when the network is disconnected, socket.io cannot detect that the network is disconnected and will not enable reconnect. So fix this problem.