Properly formats disconnectSync URI and sends it#452
Merged
rauchg merged 1 commit intosocketio:masterfrom Jul 20, 2012
Merged
Conversation
Also, fixes an issue if using https AND InternetExplorer on crossdomain sites. In these cases the use of XDomainRequest was not working because it relied on checks to see if the protocols matched or not. For some reason, paramaters weren't being passed around and so these checks failed incorrectly.
rauchg
added a commit
that referenced
this pull request
Jul 20, 2012
Properly formats disconnectSync URI and sends it
Contributor
|
Nice find @crickeys |
Contributor
Author
|
Thanks! Fast Merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, fixes an issue if using https AND InternetExplorer on crossdomain
sites. In these cases the use of XDomainRequest was not working because
it relied on checks to see if the protocols matched or not. For some
reason, paramaters weren't being passed around and so these checks
failed incorrectly.