handshake: XHR status 0 is not handled#486
Closed
szymonc wants to merge 1 commit intosocketio:masterfrom
Closed
Conversation
The handshake method do not handle the situation when xhr status is equal 0. This happens when the provided url dont give any response. When it happens also the error message is empty. I would like to try to reconnect if the socket option 'reconnect' was set to true. Changed methods: Socket.prototype.handshake - handle case when xhr status 0 Socket.prototype.onError - handle new error when xhr status == 0
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handshake method do not handle the situation when xhr status is equal 0.
This happens when the provided url dont give any response. When it happens also the error message is empty.
I would like to try to reconnect if the socket option 'reconnect' was set to true.
Changed methods:
Socket.prototype.handshake - handle case when xhr status 0
Socket.prototype.onError - handle new error when xhr status == 0