Fix to manage namespace disconnection and reconnection#568
Closed
ifraixedes wants to merge 1 commit intosocketio:0.9from
Closed
Fix to manage namespace disconnection and reconnection#568ifraixedes wants to merge 1 commit intosocketio:0.9from
ifraixedes wants to merge 1 commit intosocketio:0.9from
Conversation
…nnections (not the whole socket) and later reconnections to the same namespace
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was struggling to manage the namespace client disconnection in the application that we are working.
I realised that when the client disconnect from a namespace, after if I tried to connect again to the same namespace, it didn't receive the messages from the server, at least if the client reconnected the socket to the same namespace some seconds after he had disconnected it.
After debugging the code for awhile, I found this fix.
This pull request corresponds to another pull request to socket.io that I've done: #1296