Fixed JSONP-Polling's this._insertAt.parentNode.insertBefore() call (collision with jQuery!)#82
Closed
saschagehlich wants to merge 1 commit intosocketio:masterfrom
saschagehlich:master
Closed
Fixed JSONP-Polling's this._insertAt.parentNode.insertBefore() call (collision with jQuery!)#82saschagehlich wants to merge 1 commit intosocketio:masterfrom saschagehlich:master
saschagehlich wants to merge 1 commit intosocketio:masterfrom
saschagehlich:master
Conversation
Contributor
|
Fixed |
|
@guille can you point to where you fixed this? As of the current master branch, |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that there can be collisions with jQuery's way of fetching data through JSONP: jQuery appends the "head" tag OR appends document.documentElement. In case of appending the documentElement (e.g. the html tag) socket.io tries to get the parentNode of the html-tag which is undefined, so .insertBefore() does not work anymore.
I fixed that so socket.io uses the "head" tag to include JSONP scripts.