Fix for xhr-multipart buffering issue that causes premature onData events to be fired.#83
Closed
Croy9000 wants to merge 1 commit intosocketio:masterfrom
Closed
Fix for xhr-multipart buffering issue that causes premature onData events to be fired.#83Croy9000 wants to merge 1 commit intosocketio:masterfrom
Croy9000 wants to merge 1 commit intosocketio:masterfrom
Conversation
…ents to be triggered.
|
I've run into this problem myself. Everything works anyway when all the data finally comes in, but it's alarming. Hope your fix is correct and that it's snarfed up. |
Contributor
|
Looks like the changes have already been made. |
Contributor
|
Yep |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a large message is received via xhr-multipart, multiple Transport.prototype._onData events are triggered for the same message, causing JSON.parse errors. This fix ensures the entire message is buffered before triggering the event.