a package.json so we can get this up on npm!#88
Conversation
Author
|
Ignore this, I found a way to pull out the socket.io.js browser source from the |
This was referenced Jan 8, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like this module to be up on npm so I can just require() it browser-side with my browserify module in order to bundle the dnode browser source more sanely. Right now dnode v0.5.x sends a simulated request to some hackish internal response handler to get the browser source from the socket.io module on npm already, but this would be so much more elegant and less likely to break in future releases. I'm open to any package name, so long as this gets up on npm one way or another!