Conflicting @types/node version

[andrejleitner]

Describe the bug
There is fixed version of node types defined as socket.io dependency causing conflicts.

socket.io/package.json

Line 48 in 12221f2

"@types/node": "^14.14.10",

To Reproduce

• install other version of @types/node as your dev dependency of your project (e.g. @types/node@12)
• install socket.io@3 as original dependency of your project
• try to compile typescript file, you will get the following error:

node_modules/socket.io/dist/client.d.ts:1:23 - error TS4090: Conflicting definitions for 'node' found at
'~/example_project/node_modules/socket.io/node_modules/@types/node/index.d.ts' and
'~/example_project/node_modules/@types/node/index.d.ts'.
Consider installing a specific version of this library to resolve the conflict.

1 /// <reference types="node" />

[ironicbrew]

Unable to reproduce following the above instructions, everything compiles on my end without issue even with conflicting @types/node dev dep versions in my app vs. socket io

Can you try to rm -rf node_modules and reinstall with npm i? A bungled package-lock.json might be the issue here.

If that doesn't work I'd need a repo to clone that reproduces this issue as something is key is missing from the reproduction instructions, perhaps some setting in tsconfig.json is causing the build to trip?

[andrejleitner]

Hey @ironicbrew, thanks for looking at it. Before posting it here, I've tried a clean installation exactly as you suggested. It just didn't help. Btw. doesn't it make sense to have that and other @types defined as dependencies (non-dev)?

[Sumolari]

Btw. doesn't it make sense to have that and other @types defined as dependencies (non-dev)?

I was about to open a different issue about moving @types/node to devDependencies. It's a big package (around 740kb) and it should give no value on runtime.

[ironicbrew]

@andrejleitner, Are you using any additional config in your tsconfig that may be a little more strict than mine?

Only other thing I can think of is if you fork the repo and switch the troublesome dependency to a devDependency as suggested by @Sumolari and then npm install that it would be interesting to see if that resolved the issue.

[darrachequesne]

@andrejleitner I could indeed reproduce, thanks.

I see two possible solutions:

• put the types as devDependencies (which was the case before Missing type definitions in Socket.IO 3.x #3690)
• use a more relaxed version, for example "@types/node": ">=10", instead of "@types/node": "^14.14.10",

This comment suggests to go for the latter.

What is your opinion on this?

[andrejleitner]

Thanks @darrachequesne for checking and for the link to interesting reading too. I quite like also the latter comment, but don't have a strong opinion either.

However, the second option seems right to me, at least having this definition here:

socket.io/package.json

Line 92 in 7467216

"node": ">=10.0.0"

... and it should fix the conflict (the original issue).

[darrachequesne]

Fixed by 67a61e3, included in socket.io@3.1.2.