Closed
Conversation
darrachequesne
added a commit
that referenced
this pull request
Jul 4, 2024
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I've added a configurable option to the logger to allow for human-readable timestamps to be output to the socket.io log.
It's really helped us when debugging problems with our app so I thought it was something that others could use as well.
I've defaulted timestamps to be off initially unless you set 'log timestamps' to be true.
I was going to write a test for this but couldn't think of one that wasn't brittle, i.e. I wanted to look for indexOf the current Year in the data of the console output but even that could break at the end of the year. Probably a stupid thing to worry about though so if you want me to add a test or have an idea on how I can test for it better please let me know.
Cheers,
Ganesh