Prevent clearing of client.request and client.response for XHR and JSONP polling#102
Closed
danielbeardsley wants to merge 1 commit intosocketio:masterfrom
Closed
Prevent clearing of client.request and client.response for XHR and JSONP polling#102danielbeardsley wants to merge 1 commit intosocketio:masterfrom
danielbeardsley wants to merge 1 commit intosocketio:masterfrom
Conversation
before client 'connected' event using long-polling
Contributor
|
We'll expose normalized information directly through a public API (decoded |
darrachequesne
pushed a commit
that referenced
this pull request
Jul 4, 2024
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
darrachequesne
added a commit
that referenced
this pull request
Jul 8, 2024
AMD and browser exports are useless here.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listening to the client 'connect' message, clients using the XHR and JSONP polling protocols have no request or response attribute so I can't get access to the cookies. With both of these protocols, calling
_write()callsonClose()and clears the requrst and response variables. I've just made a change that keeps these around until the next request, so request.headers.cookies is still available. Not sure if this is appropriate for the official repo, but it worked for me.