Merged
Conversation
9b839ee to
702818f
Compare
702818f to
c6bc3e9
Compare
Contributor
|
Wouldn't it be better to use a |
d481a18 to
a1c38a2
Compare
Contributor
|
Object would be better for now, since there is no |
Member
Author
|
@nkzawa yes, that's my opinion too 👍 If we'd want to use ̀Map` (and more generally the ES2015 features) and still keep support of node < 0.12, I think a migration to Babel (or other) would be necessary (but that's out of the scope here) |
Contributor
|
In the meantime we can merge this. |
Contributor
a2e98f2 to
cecdca3
Compare
cecdca3 to
b73d9be
Compare
Member
Author
|
Done! 👼 |
Contributor
There was a problem hiding this comment.
You're not checking for hasOwnProperty here. Extensions fo the natives will make socket.io break here. Test needed for that scenario as well.
Closed
Member
Author
|
Hi! I opened a new PR to clean this ugly one: #2322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #2199