Use fs.readFileSync instead of require.resolve

[a-lucas]

The kind of change this PR does introduce

• a bug fix
• a new feature
• an update to the documentation
• a code change that improves performance
• other

Current behaviour

Browserify doesn't supports require.resolve, and as a consequence, makes nexe fails the compilation :

New behaviour

This PR attempts to read the content of the socket.io-client file via fs.readFileSync and falls back to the original require.resolve if this file cannot be found.

Other information (e.g. related issues)

nexe/nexe#289

[darrachequesne]

Hi, thanks for the PR! How about using the following:

function resolvePath(file){
  var filepath = path.resolve(__dirname, './../../', file);
  if (exists(filepath)) {
    return filepath;
  }
  return require.resolve(file);
}

Can you confirm the client file gets properly served that way? (you can also disable serving the client file with serveClient: false)

[darrachequesne]

Else, brfs may be helpful here, if you actually want to serve the file.

[a-lucas]

@darrachequesne I never heard of brfs before, I also reckon your first suggestion is the best one, much DRYer, and also it doesn't requires an additional dependency.

Yes it works, nexe works great with socket.io with this change.

[darrachequesne]

Thanks!

[a-lucas]

Thanks too! Socket.io is great!

[khuongduybui]

Has this been released? I'm using socket.io 2.0.4 and is still plagued with "require.resolve" calls.

[Bolandish]

I'm also getting this error..