Skip to content

Adding namespace.engine.generateId option#2880

Merged
darrachequesne merged 4 commits intosocketio:masterfrom
efkan:patch-1
Mar 29, 2017
Merged

Adding namespace.engine.generateId option#2880
darrachequesne merged 4 commits intosocketio:masterfrom
efkan:patch-1

Conversation

@efkan
Copy link
Contributor

@efkan efkan commented Feb 27, 2017

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

With this guidance, users can learn how to assign custom socket ids to connections on the server side.

@darrachequesne
Copy link
Member

Shouldn't it be server.engine.generateId instead?

@efkan
Copy link
Contributor Author

efkan commented Mar 2, 2017

It has been changed as you said.

Sorry for my misunderstanding.

@darrachequesne darrachequesne merged commit c5b7738 into socketio:master Mar 29, 2017
@darrachequesne
Copy link
Member

@efkan thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants