Activating Open Collective#2933
Closed
xdamman wants to merge 2 commits intosocketio:masterfrom
opencollective:opencollective
Closed
Activating Open Collective#2933xdamman wants to merge 2 commits intosocketio:masterfrom opencollective:opencollective
xdamman wants to merge 2 commits intosocketio:masterfrom
opencollective:opencollective
Conversation
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2017
Member
|
Merged as 0d07c47. I'm not really fond of the |
Contributor
Author
|
It's not but it's a nice touch to ask for donations. Have you tried it? You can also pass it the |
Member
|
@xdamman I am still not convinced that adding another dependency (something like 49 Mo if I'm not mistaken) is really necessary here. Besides, what will happen if webpack and babel and mocha and gulp... all add that postinstall script? |
Contributor
Author
|
I see 22MB on my machine. But that's highly variable depending on what other modules you already have installed in your project. If other projects also have it, npm is smart enough to only install it once. |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge this pull request to activate your Open Collective https://opencollective.com/socketio