Adding rail guard to dispatch's event param#3140
Closed
Chopinsky wants to merge 1 commit intosocketio:masterfrom
Chopinsky:fix/TypeError
Closed
Adding rail guard to dispatch's event param#3140Chopinsky wants to merge 1 commit intosocketio:masterfrom Chopinsky:fix/TypeError
Chopinsky wants to merge 1 commit intosocketio:masterfrom
Chopinsky:fix/TypeError
Conversation
|
Would you be interested in software that automatically finds TypeErrors like this? I am building Fuzz Stati0n to do that (free for OSS) - please take a look and consider signing up for our newsletter to keep in touch. |
darrachequesne
added a commit
to socketio/socket.io-parser
that referenced
this pull request
Feb 25, 2018
Member
|
Closed by socketio/socket.io-parser#83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
When event packet received by
oneventdoesn't contain a valid array as the value of thedataproperty, the subsequent call to dispatch will cause aTypeError, because theapplycall onemitwould expect the 2nd parameter to be an array type.New behaviour
Now if event packet's
dataproperty is not already an array, we will convert it to an array before passing it to theapplycall, to avoid theTypeErrorexception on rare occurrence of the problem as raised in issue #3139.Other information (e.g. related issues)
There seem to be quite a few other places that would use a similar array type check in
socket.js, but would rather hold off on updating all these places until further reporting of theTypeErrorexceptions.