Skip to content

Buffer is deprecated fix#3481

Merged
darrachequesne merged 2 commits intosocketio:masterfrom
flaambe:fix-buffer-deprecated
Sep 20, 2019
Merged

Buffer is deprecated fix#3481
darrachequesne merged 2 commits intosocketio:masterfrom
flaambe:fix-buffer-deprecated

Conversation

@flaambe
Copy link
Contributor

@flaambe flaambe commented Aug 21, 2019

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Buffer() is deprecated warning message in test

New behaviour

No warning message in test

Other information (e.g. related issues)

@darrachequesne darrachequesne merged commit 4d01b2c into socketio:master Sep 20, 2019
@darrachequesne
Copy link
Member

@flaambe great, thanks 👍

@flaambe flaambe deleted the fix-buffer-deprecated branch September 20, 2019 16:49
@darrachequesne darrachequesne added this to the 2.3.0 milestone Sep 28, 2020
This was referenced Mar 17, 2021
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants