Setting disconnected = true prior to firing disconnect event, to avoid sc#484
Closed
tommedema wants to merge 1 commit intosocketio:masterfrom
tommedema:patch-1
Closed
Setting disconnected = true prior to firing disconnect event, to avoid sc#484tommedema wants to merge 1 commit intosocketio:masterfrom tommedema:patch-1
tommedema wants to merge 1 commit intosocketio:masterfrom
tommedema:patch-1
Conversation
Author
|
I just tested if this fixed #483 and unfortunately it did not. However, disconnected should be set to true in the disconnect event so this still fixes an (undocumented) bug. |
…d scenario where socket disconnected is set to false inside disconnect event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting disconnected = true prior to firing disconnect event, to avoid scenario where socket disconnected is set to false inside disconnect event.
Should fix #483, although not tested.