Few optimisations and bug fixes.#53
Merged
3 commits merged intosocketio:masterfrom Sep 17, 2010
3rd-Eden:master
Merged
Conversation
…onclose netserver.close will fail because netserver will be undefined.
…and over again just makes no sense + it hurt performance.. Not to mention.. that it's already included.
darrachequesne
pushed a commit
that referenced
this pull request
Jul 4, 2024
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
Remove browsers setting from .zuul.yml
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was the "ECONNRESET, Connection reset by peer" issues that are being caused by socket.io I stumbled on some weird code.
These patches should make the code more sense, improve overall performance and actually prevent a few bugs from happening.