Socket.IO .listen() options, added host as option#655
Closed
danielburhans wants to merge 1 commit intosocketio:masterfrom
Closed
Socket.IO .listen() options, added host as option#655danielburhans wants to merge 1 commit intosocketio:masterfrom
danielburhans wants to merge 1 commit intosocketio:masterfrom
Conversation
…n on different Network Interfaces.
|
Why isn't this pull request accepted? I too would like this feature. |
|
I'm looking for this feature too. Will probably monkey patch in the meantime. |
Contributor
|
The reality is that you can still pass a http server. |
|
Ah right, thanks for pointing that out! |
darrachequesne
pushed a commit
that referenced
this pull request
Jul 4, 2024
Fix incorrect ports in connection URL
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
The "addTrailingSlash" option allows to control whether a trailing slash is added to the path of the HTTP requests: - true (default): "/engine.io/" - false: "/engine.io" Related: socketio/engine.io-client@21a6e12 Signed-off-by: iifawzi <iifawzie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am semi-new to Node.JS but this was a simple add-in for configuring socket.io to support hostname/network interface binding specifics, as I do not see a way to directly assign socket.io to a specific network interface.
The only draw back I can see is that host gets passed into https createServer as an option, but it does not seam to affect server creation.