Merged
Conversation
…s not getting passed through onClientDisconnect().
Contributor
|
This broke the test suite: http://travis-ci.org/#!/LearnBoost/socket.io/builds/345652 |
Contributor
|
Yup I noticed. Reverting |
Contributor
Author
|
Tests running locally fine. What's your local results? |
Contributor
|
@dshaw just create another pull req ;)? |
Contributor
Author
|
@3rd-Eden AFK. Will do. Github won't let me simply re-request. http://cl.ly/2R0o2H3E1E3A2B2f0H3S |
Contributor
|
Awell @guille would just have to do a regular, oldschool branch and merge than ;) On Dec 6, 2011, at 2:14, Daniel Shawreply@reply.github.com wrote:
|
simonratner
pushed a commit
to simonratner/socket.io
that referenced
this pull request
Jun 19, 2013
Patch/redis disconnect
simonratner
pushed a commit
to simonratner/socket.io
that referenced
this pull request
Jun 19, 2013
Patch/redis disconnect
|
It appears this change never made it into the 0.9 branch. |
simonratner
pushed a commit
to simonratner/socket.io
that referenced
this pull request
Apr 22, 2014
Patch/redis disconnect
simonratner
pushed a commit
to simonratner/socket.io
that referenced
this pull request
Apr 22, 2014
Patch/redis disconnect
darrachequesne
pushed a commit
that referenced
this pull request
Jul 8, 2024
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispatch client disconnect events correctly and fix leaking Redis subscriptions.