Target node v0.7.4#875
Closed
sonnym wants to merge 2 commits intosocketio:masterfrom
sonnym:target_node_v0.7.4
Closed
Target node v0.7.4#875sonnym wants to merge 2 commits intosocketio:masterfrom sonnym:target_node_v0.7.4
sonnym wants to merge 2 commits intosocketio:masterfrom
sonnym:target_node_v0.7.4
Conversation
the motivation behind these changes is that in upcoming versions of node, sys will finally be deprecated
package.json
Outdated
Contributor
There was a problem hiding this comment.
You shouldn't change engines. I'm sure we'll want to support v0.6.x for a little while longer.
This reverts commit 9319a77 partially so as to not update the supported engines
Author
|
Makes sense - I've reverted that part of the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I've been working on updating some of my code to work with the current unstable branch of node. It looks like they have decided to change the sys library deprecation warning to an outright error.
The changes herein will work with at least node v0.7.4, but a couple additional tests break with v0.7.8, so I left it at this.
I just figured I would forward this along in case it can help you get a head start with getting ready for the next node release. Please drop me a line if you would like me to make any additional changes to this pull request.
Thanks!