Windows: Fix build error incompatible pointer types#81
Merged
ioquatix merged 2 commits intosocketry:masterfrom May 17, 2024
Merged
Conversation
On GitHub workflows, building the native extensions for `cool.io` fails
as follows:
../libev/ev.c: In function 'evpipe_write':
../libev/ev.c:2484:19: error: assignment to 'char *' from incompatible pointer
type 'WSABUF *' [-Wincompatible-pointer-types]
2484 | buf.buf = &buf;
| ^
* Runner: windows-2022 (20240421.1.0)
* Use `ruby/setup-ruby v1` to set up Ruby
* https://github.com/actions/setup-ruby
* Dependency: `cool.io` v1.8.0
The type of `buf` member of `WSABUF` is `char *`:
* https://learn.microsoft.com/en-us/windows/win32/api/ws2def/ns-ws2def-wsabuf
On `libev` upstream, this was already fixed on v4.25:
http://cvs.schmorp.de/libev/ev.c?r1=1.484&r2=1.485&pathrev=rel-4_25
Maybe we should try to update the overall `libev` version, but that
could be difficult.
So, this commit intends to fix this error first.
In addition, add `fail-fast: false` to ensure that all jobs are executed.
Contributor
Author
|
@ioquatix Could you please see this? |
Contributor
Author
|
Thanks for your review! |
Member
|
I released it in version 1.8.1. Please let me know how you get on. |
Contributor
Author
Thanks! Sure! |
Contributor
Author
|
@ioquatix I have confirmed this issue is completely resolved! |
Member
|
Thanks for your pull request and additions to CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub workflows, building the native extensions for
cool.iofails as follows:ruby/setup-ruby v1to set up Rubycool.iov1.8.0I have tested this by enabling Windows CI on my fork.
You can see this error occurs on Windows:
In addition, I have made the test repository that depends on
cool.io.You can check this error here too:
About this fix
The type of
bufmember ofWSABUFischar *:On
libevupstream, this was already fixed on v4.25:http://cvs.schmorp.de/libev/ev.c?r1=1.484&r2=1.485&pathrev=rel-4_25
Maybe we should try to update the overall
libevversion, but that could be difficult.This PR intends to fix this error first.
Types of Changes
Contribution