Use io_uring_prep_waitid for process_wait in URing selector #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check for the existence of both `io_uring_prep_waitid` and `rb_process_status_new`. See also github.com/ruby/ruby/pull/15213. Note: the use of `pidfd_open`` (and then polling on the fd) means that doing `Process.wait(-1)` or `Process.wait(0)` will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of process_wait using
io_uring_prep_waitidwhen available. Since we also need to directly instantiate aProcess::Statusobject, we also check for the existence ofrb_process_status_new(see ruby/ruby#15213).Note: the use of
pidfd_open(and then polling on the fd) means that doingProcess.wait(-1)orProcess.wait(0)will fail.Types of Changes
Contribution