Allow mixed key types for parts headers #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
reviewed
Dec 28, 2021
Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
Contributor
Author
|
@patrickdavey - Do you have any feedback for me on this PR? Thanks. |
Member
|
This looks okay to me. |
olleolleolle
added a commit
to olleolleolle/multipart-post
that referenced
this pull request
Jun 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into this issue when attempting to implement the Parts Headers example
If the param has a string key, but the key in the headers is a symbol, the additional headers will not be supplied. In the example in the README the following key is a string:
while the header has a symbol for a key:
This example does not work with the current code.
Types of Changes
This PR forces the keys to a symbol when retrieving the headers, ensuring a match.
Testing