[Repo Assist] fix: consolidate critical bug fixes (pre-v0.0.10)

[github-actions]

🤖 This is an automated draft PR from Repo Assist, an AI assistant.

Summary

Consolidates the most critical bug fixes from the many open Repo Assist PRs into a single reviewable change. This is the same set of fixes as the blocked issue #98, but without the package.json version bump so this PR can be created and reviewed now. The version bump can be done separately before release.

Changes

Bug Fixes

• Fix hang when nothing to fix — exit code 0 now calls reject() cleanly instead of leaving the promise unresolved. Closes Indent when saving does not work if phpcbf has nothing to indent #39.
• Always close stdin regardless of debug mode, preventing onWillSaveTextDocument timeout errors on some phpcbf builds. Closes onWillSaveTextDocument-listener error #35.
• Use path.join() for temp file path — fixes path separator issues on Windows. Closes Use path.sep when building path to temporary file #23.
• Set cwd: TmpDir in cp.spawn — so phpcbf can write temporary diff files even on macOS/Linux where the default cwd may be read-only. Closes Detect phpcs version and add option --no-patch if version 2.* #16.
• Fix fs.exists async race in addRootPath() — replaced with synchronous fs.existsSync so executablePath is always resolved before format() runs. Closes executablePath broken #36.
• Fix exit code 3 stdout handling — stdout listener was registered after spawn, so errors were never shown. Now stdoutOutput is collected during the whole lifecycle.
• resolve([]) instead of reject() in provideDocumentFormattingEdits when no changes are needed — eliminates spurious "Formatter failed" notifications. Closes Warning in debugger tools when saving file #19.
• Read phpcbf.onsave per-document URI in onWillSaveTextDocument so per-folder settings in multi-root workspaces work correctly. Closes add ignorePatterns configuration #27.
• Only reload settings on phpcbf.* config changes — prevents unnecessary loadSettings() calls on every VS Code settings change.
• Resolve ~, ./, \$\{workspaceFolder}, \$\{workspaceRoot} in phpcbf.standard — so paths like "~/standards/ruleset.xml" or "./phpcs.xml" work without hardcoded paths. Closes ${workspaceRoot} inside phpcbf.debug #7, phpcbf.standard doesn't allow relative paths or ${workspaceFolder} #38.
• Clean up temp file on spawn error — previously the temp file was leaked on the error path.

Relationship to Other Open PRs

This PR supersedes (those can be closed once this merges):

• [Repo Assist] fix: consolidate critical bug fixes in format() and related helpers #69 (consolidated critical fixes — subset of this PR)
• [Repo Assist] fix: always close stdin in format() regardless of debug mode (closes #35) #90, [Repo Assist] fix: always close stdin in format() regardless of debug mode #92 (stdin close fix)
• [Repo Assist] fix: resolve([]) instead of reject() in provideDocumentFormattingEdits (closes #19) #88 (resolve([]) fix)
• [Repo Assist] fix: read phpcbf.onsave per-document URI in onWillSaveTextDocument #68 (per-document onsave)
• [Repo Assist] fix: set cwd to TmpDir in cp.spawn for phpcs 2.x compatibility #73 (cwd: TmpDir)
• [Repo Assist] fix: resolve relative paths and ~ in phpcbf.standard against workspace root #65 (relative paths in standard)
• [Repo Assist] fix: only reload settings when phpcbf configuration changes #86 (config reload filter)
• [Repo Assist] fix: show user-visible error for non-ENOENT spawn failures (fixes #15) #80 (non-ENOENT error messages)
• [Repo Assist] fix: clean up temp file in process error handler to prevent resource leak #58 (temp file cleanup on error)

Note: package.json version bump is intentionally excluded (protected file). The maintainer can bump the version to 0.0.10 and update CHANGELOG.md date before merging.

Test Status

✅ Unit tests pass: npm run test:unit — 7/7 tests pass
✅ Syntax check: node --check extension.js — no syntax errors
⚠️ Integration tests: VS Code integration tests require a GUI environment and cannot run in CI. The logic changes are unit-testable; the formatting provider changes follow the VS Code extension API contract.

Closes

Closes #7, #16, #19, #27, #35, #36, #38, #39

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f