Skip to content

[Repo Assist] fix: reject promise on phpcbf exit codes 0 and 3 to prevent hang #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Repo Assist] fix: reject promise on phpcbf exit codes 0 and 3 to prevent hang #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ class PHPCBF {
*/
switch (code) {
case 0:
// Nothing to fix; signal to VS Code that there are no edits.
reject();
break;
case 1:
case 2:
Expand All @@ -204,6 +206,8 @@ class PHPCBF {
break;
case 3:
phpcbfError = true;
// Reject so the promise does not hang indefinitely.
reject();
break;
default:
let msgs = {
Expand Down