Skip to content

[All] Clean types #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bakpaul merged 2 commits into from
Apr 24, 2025
Merged

[All] Clean types #175

bakpaul merged 2 commits into from
Apr 24, 2025

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 16, 2025 •
edited
Loading

Cleaning (a bit) the cesspool 🥴 in the interpolation/shape part

  • remove all the const ref for simple types
  • use more sane types for IDs/size (and use aliases for clearer intent)
  • add some const for more clarity for inputs/outputs

Breaking as it changes a lot of method signatures

@fredroy fredroy added pr: clean pr: status to review To notify reviewers to review this pull-request labels Apr 16, 2025
@fredroy fredroy mentioned this pull request Apr 18, 2025
Merged
alxbilger
alxbilger approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxbilger alxbilger added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 23, 2025
@bakpaul bakpaul merged commit cf46ccd into sofa-framework:master Apr 24, 2025
15 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxbilger alxbilger alxbilger approved these changes

@bakpaul bakpaul bakpaul approved these changes

Assignees

No one assigned

Labels

pr: clean pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredroy @alxbilger @bakpaul