[IRC] Add checks/warnings at init stage #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: clean
pr: status to review
fredroy
force-pushed
the
update_mech_checks
branch
from
4f428ea to
ef8b05e
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
added
pr: status ready
fredroy
force-pushed
the
update_mech_checks
branch
from
ef8b05e to
5ab0aff
Compare
fredroy
force-pushed
the
update_mech_checks
branch
from
5ab0aff to
aa9b355
Compare
epernod
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of
If the required MechanicalObject and topology is not well set (number of nodes, edges), the warning comes during the simulation runtime (which will be too late).
So in this PR we check at the init stage and inform the user already.
Hesitating to