Add new env.var to set a build configuration at runtime #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
reviewed
Jul 15, 2024
fredroy
added
pr: status wip
pr: status to review
and removed
pr: status to review
pr: status wip
labels
fredroy
force-pushed
the
config_multibuild_win32
branch
from
f282d5f to
cc8aa46
Compare
hugtalbot
reviewed
Jul 17, 2024
alxbilger
approved these changes
Jul 17, 2024
fredroy
force-pushed
the
config_multibuild_win32
branch
from
539dbd9 to
dbf694e
Compare
fredroy
commented
Jul 31, 2024
alxbilger
reviewed
Jul 31, 2024
alxbilger
approved these changes
Jul 31, 2024
damienmarchal
pushed a commit
that referenced
this pull request
Sep 13, 2024
* add new env.var to set build configuration at runtime * remove comment about old behavior * test * Update .github/workflows/ci.yml * Update bindings/Sofa/package/__init__.py --------- Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Sometimes it is frustrating with MSVC config that python3 interpreter choose a bad build directory for SOFA_ROOT because he just find the first build directory with Sofa.Helper.dll. So if you have both Release and RelWithDebInfo, it will always choose the first one, even if you are currenty working with the second one.
So this PR introduces a new envvar to force choose a configuration, called
SOFA_BUILD_CONFIGURATION.Actually it can also be useful if a user uses a custom name for the configuration type (other than release, relwithdebinfo, etc)
Note that this feature would be useful for macOS/XCode but for the moment SofaPython3 always considered macOS like Linux/{makefile/ninja}, i.e with a single configuration mode.