Fix all tests on Windows #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
damienmarchal
added a commit
to CRIStAL-PADR/plugin.SofaPython3
that referenced
this pull request
Apr 11, 2022
The object created from python needs special care to avoid being deleted by the python garbage collection mecanisme. In sofa-framework#74 and sofa-framework#75 the smart pointer mecanism was refactored. The refactoring added a py::keep_alive, in addObject but didn't in other functions. The PR fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally fixes all failing tests and segmentation faults with virtual classes (python Controller -> C++ Controller, and python Forcefield -> C++ Forcefield).
In addition, building SofaPython3 in-tree (within the SOFA build) now places the python test files and binding libraries at their correct place, both in multi-configurations builds (MSVC) and standard builds. It should now be safe to load SofaPython3 from an in-tree build directory, in-tree install directory, out-of-tree build directory and out-of-tree install directory.
We are getting closer and closer to a first stable release.
This PR fixes #39