Open
Conversation
Likely incomplete- but I *think* this passes the token around correctly now.
…w update the token on an instantiated SofarAPI object and it is respected in all subsequent uses of the API (including when passing it to a Spotter object). Note that this pull also changes the default .env search logic from: `look in user directory for sofer_api.env and load token from that` To `look in user directory for sofer_api.env and load token from that, if no file is present use default dotenv logic through find_dotenv()` This preserves legacy behaviour- but otherwise moves towards more standard behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to token handling/usage from @pieterbartsmit —
pysofar, including workers and subclasses.envfile if customsofar_api.envfile is not present