Skip to content

[UNI-238] feat : 현재 버전과 특정 버전의 차이점 조회 API 구현#143

Merged
thdgustjd1 merged 11 commits intobefrom
feat/UNI-238
Feb 15, 2025
Merged

[UNI-238] feat : 현재 버전과 특정 버전의 차이점 조회 API 구현#143
thdgustjd1 merged 11 commits intobefrom
feat/UNI-238

Conversation

@thdgustjd1
Copy link
Copy Markdown
Collaborator

@thdgustjd1 thdgustjd1 commented Feb 15, 2025

📝 PR 타입

  • 기능 구현
  • 기능 수정
  • 버그 수정
  • 리팩토링
  • 인프라, 의존성, 환경 변수, 빌드 관련 코드 업데이트

🚀 변경 사항

특정 버전과 현재 버전의 차이점을 조회하는 API 개발

로직 구현 배경 및 목적

  • 현재 저희 서비스에서 지도를 불러오는 로직은 무거운 로직입니다. 이로 인하여 매번 지도를 불러올 경우 사용자 경험에 영향을 주었고, 이를 해결하고자 하였습니다.
  • 우선 클라이언트 단에서 캐시되어있는 지도 데이터를 사용자에게 제공하여 First Contentful Paint (첫 컨텐츠 렌더링 시점)를 단축시켰습니다.
  • 이후 별도의 API호출을 통해 변경사항들을 후처리함으로써 데이터의 최신성을 보장할 수 있게 되었습니다.

구현내용

🧪 테스트 결과

  • 테스트코드를 확인해보시면 좋을 것 같습니다
스크린샷 2025-02-15 오후 7 17 38

@thdgustjd1 thdgustjd1 added 🚀 feat 기능 개발 🫀 be 백엔드 task labels Feb 15, 2025
@thdgustjd1 thdgustjd1 requested a review from mikekks February 15, 2025 05:58
@thdgustjd1 thdgustjd1 self-assigned this Feb 15, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Collaborator

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로 versionId 는 모든 지도 조회 API 에서 같이 주는게 좋겠죠?!

@thdgustjd1
Copy link
Copy Markdown
Collaborator Author

추가로 versionId 는 모든 지도 조회 API 에서 같이 주는게 좋겠죠?!

네 맞습니다!

@thdgustjd1 thdgustjd1 changed the title [UNI-238] 테스트PR (do not merge) [UNI-238] feat : 현재 버전과 특정 버전의 차이점 조회 API 구현 Feb 15, 2025
Copy link
Copy Markdown
Collaborator

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~!

궁금한 부분은 댓글 남겼습니다 :)

Copy link
Copy Markdown
Collaborator

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 ~!!

@thdgustjd1 thdgustjd1 merged commit 8248f8d into be Feb 15, 2025
@thdgustjd1 thdgustjd1 deleted the feat/UNI-238 branch February 15, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🫀 be 백엔드 task 🚀 feat 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants