[ALL-Fix] actions 파일 중 scp 파일 경로 수정 #347
Conversation
- backend_deploy.sh, frontend_deploy.sh - nginx/backend.conf frontend.conf - fe-cd.yml, be-cd.yml 수정 (설정 파일을 ec2 서버로 전송하는 코드 추가)
WalkthroughThis pull request updates the GitHub Actions deployment workflows by modifying the Changes
Sequence Diagram(s)sequenceDiagram
participant GitHubActions as GitHub Actions
participant DeployJob as Deployment Job
participant EC2 as EC2 Instance
GitHubActions->>DeployJob: Trigger deployment workflow
DeployJob->>DeployJob: Determine strip_components for each file copy
DeployJob->>EC2: Copy file(s) with adjusted path (stripping N components)
EC2-->>DeployJob: Confirm file received and placed
DeployJob-->>GitHubActions: Report job success
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/fe-cd.yml (1)
49-49: Confirm the correct stripping for Nginx files.
Thestrip_componentsvalue for copying Nginx files was updated from1to3, which will remove three leading directory levels from the source path. Verify that this adjustment positions the Nginx configuration files correctly in the target directory on the EC2 instance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/be-cd.yml(1 hunks).github/workflows/fe-cd.yml(2 hunks)
🔇 Additional comments (2)
.github/workflows/be-cd.yml (1)
51-51: Verify the updatedstrip_componentsvalue.
The parameter has been updated from1to2in the "Copy deploy_script to EC2" step. This change should now remove two leading components from the source file path. Please ensure that the resulting file layout on the EC2 instance matches the intended structure..github/workflows/fe-cd.yml (1)
59-59: Validate the updated strip for the frontend deploy script.
Here,strip_componentshas been changed from1to2to ensure that extra directory levels are removed from the deploy script’s path. Please check that this modification results in the expected file structure on deployment.
#️⃣ 연관된 이슈>
📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)
🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
Summary by CodeRabbit