[BE-Fix] 롱 폴링이 제대로 작동하지 않는 버그 수정

[kwon204]

#️⃣ 연관된 이슈>

📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

• 사용자가 새로 고침을 하게 될 경우 기존의 연결을 끊고 새로운 연결을 생성한다.

• 이때 setResult()를 통해 대체되었다는 응답을 하게 된다.

• setResult()가 실행되면 onCompletion()의 메소드가 실행되고

• 바로 map에 존재하던 연결을 지우게 된다.

• 결과적으로 새로고침 한 번으로 지우고 만들고 지우는 처리가 진행된다.

• 이를 해결하기 위해 onCompletion()에서 현재 연결 중인 DeferredResult가 유효한지 체크하여 유효하지 않은 경우에만 지우도록 변경하였다.

🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of user session cleanup to prevent premature or unnecessary removal of user data during certain operations.

[coderabbitai]

Walkthrough

The logic for removing user IDs from the results map in the DeferredResultManager has been updated. Now, the removal on deferred result completion is conditional: it checks if the user ID exists and if its DeferredResult is set or expired before removing. The onTimeout handler's behavior remains unchanged.

Changes

File Path	Change Summary
backend/src/main/java/endolphin/backend/global/util/DeferredResultManager.java	Modified logic for removing userId from results map on completion to be conditional, based on DeferredResult state.

Poem

In the warren of waiting, results softly hop,
Now a rabbit checks twice before making them stop.
Only if set or expired, the userId goes—
On timeout, though, out the burrow it flows.
With careful new logic, we bound and we leap,
Ensuring no promises vanish too deep.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 9355530 and 74bc8e2.

📒 Files selected for processing (1)

• backend/src/main/java/endolphin/backend/global/util/DeferredResultManager.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• backend/src/main/java/endolphin/backend/global/util/DeferredResultManager.java

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[efdao]

👍