-
Notifications
You must be signed in to change notification settings - Fork 1
[FE-Chore] Changeset 세팅 #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update introduces Changesets tooling for version management and publishing in the frontend workspace. It adds configuration, documentation, and a workflow for automated versioning and publishing. Several package names are updated, and package versions are reset to 1.0.0 with internal dependencies shifted to workspace protocol references. The frontend CI workflow is updated to enforce frozen lockfile installs. Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant GitHub
participant GitHub Actions
participant Changesets
participant npm Registry
Developer->>GitHub: Push to main
GitHub->>GitHub Actions: Trigger changesets.yml workflow
GitHub Actions->>Repository: Checkout code
GitHub Actions->>pnpm: Setup and install dependencies
GitHub Actions->>Changesets: Run Changesets action
Changesets->>GitHub: Create PR for version updates
Changesets->>npm Registry: Publish updated packages
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📥 CommitsReviewing files that changed from the base of the PR and between 348d6a0ab9418a89b2738c79a9da548747b45d5a and b090c08. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (4)
frontend/packages/date-time/package.json (1)
7-9: Non-functional formatting change
Thefilesfield has been reformatted to a multi-line array without any semantic alteration. This is fine, but ensure style consistency across other package manifests.frontend/.changeset/README.md (1)
1-9: Add Changesets README documentation.The README contextualizes the
.changesetfolder. Optionally, link to any project-specific contribution guides or PR templates to guide new contributors.frontend/.changeset/config.json (2)
2-6: Pin schema to latest or update intentionally
Consider whether you want to lock the config schema to@changesets/config@3.1.1or switch to the unversioned URL (https://unpkg.com/@changesets/config/schema.json) to automatically pick up schema updates.
7-7: Confirmcommit: falseis intended
The settingcommit: falseprevents Changesets from committing version bumps automatically. Verify this aligns with your release workflow or if you’d prefer auto-commits on themainbranch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between df5d8c1 and 348d6a0ab9418a89b2738c79a9da548747b45d5a.
⛔ Files ignored due to path filters (1)
frontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
.github/workflows/changesets.yml(1 hunks)frontend/.changeset/README.md(1 hunks)frontend/.changeset/config.json(1 hunks)frontend/.changeset/cyan-colts-rule.md(1 hunks)frontend/apps/client/package.json(1 hunks)frontend/apps/server/package.json(2 hunks)frontend/package.json(2 hunks)frontend/packages/calendar/package.json(2 hunks)frontend/packages/core/package.json(2 hunks)frontend/packages/date-time/package.json(1 hunks)frontend/packages/theme/package.json(2 hunks)frontend/packages/ui/package.json(3 hunks)
🔇 Additional comments (14)
frontend/apps/server/package.json (1)
2-2: Scoped package naming alignment
The package name has been updated to@endolphin/serverto match the monorepo conventions. Please verify that all import statements, CI/CD workflows, and documentation have been updated to reference the new scope.frontend/apps/client/package.json (1)
2-2: Scoped package naming alignment
The package name has been changed to@endolphin/client. Ensure that any downstream scripts, project references, and documentation are updated accordingly (e.g., pnpm filters, README links).frontend/packages/core/package.json (1)
3-3: Version reset to 1.0.0
The package version has been downgraded to1.0.0to align with the new Changesets workflow. Confirm that the Changesets config and release pipeline will pick up this bump correctly.frontend/packages/date-time/package.json (1)
3-3: Version reset to 1.0.0
The version has been reset to1.0.0as part of the coordinated versioning update. Please verify that the Changesets file reflects this version change.frontend/.changeset/cyan-colts-rule.md (1)
1-7: Changeset declaration for major bumps
This changeset correctly lists major version updates for the five core workspace packages. Confirm that@endolphin/serverand@endolphin/clientare excluded per.changeset/config.jsonand that the CI workflow will apply these bumps as intended.frontend/packages/theme/package.json (2)
3-3: Reset package version to 1.0.0 for consistent monorepo versioning.This aligns with the coordinated major version reset managed by Changesets. Ensure that this baseline version is correctly captured in the next release changelog.
22-22: Switch peer dependency to workspace protocol.Using
workspace:^for@endolphin/coreensures internal package resolution under pnpm workspaces. Verify that CI installs correctly with this prefix.frontend/packages/ui/package.json (2)
3-3: Reset@endolphin/uiversion to 1.0.0.This matches the monorepo-wide version reset via Changesets. Confirm all dependent packages reference this new baseline.
19-20: Use workspace protocol for internal dependencies.Switching
@endolphin/coreand@endolphin/themetoworkspace:^guarantees local linking in the monorepo. Ensure pnpm workspace resolution remains stable.frontend/packages/calendar/package.json (3)
3-3: Reset@endolphin/calendarversion to 1.0.0.Aligns with the major version reset across all frontend packages. Verify that the initial release changelog reflects this baseline.
17-18: Use workspace protocol for internal dependencies.Updating
@endolphin/coreand@endolphin/uitoworkspace:^supports monorepo-local linking. Confirm that workspace linking works as expected in CI.
23-23: Switch peer dependency to workspace protocol.Changing
@endolphin/themetoworkspace:^ensures consistent internal resolution. Double-check peer linking behavior under pnpm.frontend/.changeset/config.json (1)
12-13: Validate ignored packages
You’ve excluded@endolphin/clientand@endolphin/serverfrom changeset processing. Please confirm that no additional workspace packages should be included in the ignore list..github/workflows/changesets.yml (1)
22-26: Verify Node.js version requirement
The workflow installs Node.js 20. Ensure that all scripts and dependencies in this repo are compatible with Node 20, or adjust to your project’s LTS version if needed.
dioo1461
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!!!
348d6a0 to
b090c08
Compare
#️⃣ 연관된 이슈>
📝 작업 내용> 이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)`
Changeset세팅합니다.🙏 여기는 꼭 봐주세요! > 리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
패키지 업데이트 시 아래 사항대로 진행하시면 됩니다.
pnpm changeset명령어 입력 후, 업데이트할 패키지 선택 및 시멘틱 버저닝md파일 생성, PR 작성main브랜치로의 머지 시 버전업을 위한 PR 자동 생성Summary by CodeRabbit
New Features
Chores