Skip to content

Conversation

@camporter
Copy link
Member

@camporter camporter commented May 8, 2019

Upgrade to prompt_toolkit 2.

  • Maintain a session across prompts so that arrow up and down can go through line history.
  • Update the documented package in README.
  • Return from the completion generator rather than raising a StopIterator to stop the generator. This is so that under Python 3.7 with PEP 479 the iteration ends properly and does not throw ugly errors while typing commands.

Fixes #1042

@camporter camporter self-assigned this May 8, 2019
@allmightyspiff allmightyspiff self-requested a review May 8, 2019 21:23
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing with this error:

<Result UnsupportedOperation('Stdin is not a terminal.')>

Changes look fine otherwise.

@coveralls
Copy link

coveralls commented May 14, 2019

Coverage Status

Coverage decreased (-0.4%) to 91.725% when pulling f11a7e6 on camporter:prompt_toolkit_2_upgrade into c8f666f on softlayer:master.

@camporter
Copy link
Member Author

Unfortunately I've had to remove the tests for the shell CLI as I was not able to make them work compatibly across python versions.

@camporter camporter requested a review from allmightyspiff May 17, 2019 16:03
@allmightyspiff allmightyspiff merged commit 931ec07 into softlayer:master May 30, 2019
@allmightyspiff allmightyspiff mentioned this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prompt_toolkit 2

3 participants