Skip to content

IBMID auth support #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allmightyspiff merged 3 commits into from
Jun 25, 2019
Merged

IBMID auth support #1152

allmightyspiff merged 3 commits into from
Jun 25, 2019

Conversation

@allmightyspiff
Copy link
Member

@allmightyspiff allmightyspiff commented Jun 17, 2019 •
edited
Loading

For users wanting to use an IBMid apikey, all they need to really do is edit their config file

FOR IBMID YOUR USERNAME IS apikey LITERALLY

[softlayer]
username = apikey
api_key = <IBM ID API KEY>

This also does allow slcli config setup to setup the config with IBMid as well.

@coveralls
Copy link

coveralls commented Jun 17, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 92.229% when pulling edeff99 on allmightyspiff:issues1104 into 0803951 on softlayer:master.

@allmightyspiff allmightyspiff self-assigned this Jun 17, 2019
@allmightyspiff
Copy link
Member Author

allmightyspiff commented Jun 17, 2019

fixes #1104

@allmightyspiff
Copy link
Member Author

allmightyspiff commented Jun 17, 2019

Testing

To test you will need an cloud.ibm.com apikey, see https://cloud.ibm.com/docs/iam?topic=iam-userapikey#create_user_key

When setting up the slcli, your username is literally apikey.

  • test both Rest and XML calls
  • Test I didn't break anything with sl api key auth.
  • Test slcli config setup works with SL and IBM keys
  • test using IBM id

@allmightyspiff allmightyspiff requested a review from caberos June 17, 2019 20:51
ATGE
ATGE approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, IBMid apikey works like expected

@allmightyspiff allmightyspiff merged commit 4ec5501 into softlayer:master Jun 25, 2019
@allmightyspiff allmightyspiff deleted the issues1104 branch June 25, 2019 13:55
@allmightyspiff allmightyspiff mentioned this pull request Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

@caberos caberos Awaiting requested review from caberos

1 more reviewer

@ATGE ATGE ATGE approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allmightyspiff allmightyspiff

Labels

API CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allmightyspiff @coveralls @ATGE