Skip to content

Fix #1195 slcli vs dns-sync --ptr fails #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ATGE wants to merge 4 commits into from
Closed

Fix #1195 slcli vs dns-sync --ptr fails #1205

ATGE wants to merge 4 commits into from

Conversation

@ATGE
Copy link
Contributor

@ATGE ATGE commented Dec 20, 2019

No description provided.

@ATGE ATGE requested a review from allmightyspiff December 20, 2019 22:44
allmightyspiff added a commit to allmightyspiff/softlayer-python that referenced this pull request Dec 30, 2019
@allmightyspiff
softlayer#1205 refactored the dns_sync sub-functions for vs and hw dn…
27a1d3d 
…s-sync
@allmightyspiff
Copy link
Member

allmightyspiff commented Dec 30, 2019

So the error pylint is complaining about isn't easily fixed sadly. I went ahead and refactored the sub-functions that were all just duplicated code anyway out to the DNS manager ( I have a branch with the changes here: https://github.com/allmightyspiff/softlayer-python/tree/ATGE-issue1195 ). Which fixes the analysis checks, but breaks a few of the unit tests. I'll see if I can get the unit tests fixed before you come back from vacation.

allmightyspiff
allmightyspiff requested changes Dec 30, 2019
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to need to refactor here to make pylint checks happy. Since there is a lot of duplicated logic between the two vs/hw dns-sync commands that makes sense to me. Since your out for the next few days I'll make the changes in a different branch, and have you double check them when you get back in case I missed a detail.

@allmightyspiff allmightyspiff mentioned this pull request Jan 2, 2020
Merged
@allmightyspiff
Copy link
Member

allmightyspiff commented Jan 2, 2020

Moving these changes to #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allmightyspiff allmightyspiff allmightyspiff requested changes

Assignees

@ATGE ATGE

Labels

CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ATGE @allmightyspiff