Removed overly specific reference to Block storage #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Jul 1, 2020
Member
There was a problem hiding this comment.
Thanks for the pull request.
Looks like changing the exception broke tests/managers/block_tests.py::BlockTests::test_cancel_block_volume_exception_billing_item_not_found, .
Fix that test and add a space in the refresh_dep_dupe docblock and this should be good to go :)
SoftLayer/managers/storage.py
Outdated
|
|
||
| def refresh_dep_dupe(self, volume_id, snapshot_id): | ||
| """"Refresh a dependent duplicate volume with a snapshot from its parent. | ||
| """"Refresh a dependent duplicate volume with a snapshot from its parent.Block Storage was already cancelled |
I found a specific reference to block storage in code shared between file and block. reworded it to refer to either block or storage volumes
Contributor
Author
|
Good catch on the dep_dupe error- didn't mean to edit that actually, must have been an errant keystroke. I edited the test case, looks like everything is passing now |
allmightyspiff
approved these changes
Jul 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a specific reference to block storage in code shared between file and block. reworded it to refer to either block or storage volumes