-
Notifications
You must be signed in to change notification settings - Fork 194
Add getting package by key for use in hardware manager #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you apply this change to softlayer-python/SoftLayer/managers/vs.py Line 817 in c7e3d84
so that both hardware and virtual use your get_package_by_key method, then we can remove get_package_id_by_type |
|
@allmightyspiff I've updated the virtual manager to use get_package_by_key but I left the _by_type methods in the ordering manager. After talking with @sergiocarlosmorales I think it's best that we leave them in to prevent breaking other users applications that may include the package and use the ordering library. |
allmightyspiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
|
Agree here, if we were to remove that functionality we might break existing customer implementations and since it would be backwards incompatible, we'd likely need to bump the release version. Too much, let's keep it simple for now :) |
|
There appears to be reports of issues with packages having the same type and the package not being chosen here before this change (on 5.2.1). @allmightyspiff any way we could get a new minor or bugfix release out with this included? |
|
5.2.3 is now released. |
This addresses the issue I opened, #809.