Open
Conversation
jessbowers
force-pushed
the
fix/docker-err
branch
from
ec342f0 to
f9785cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Properly handles a crash when the docker.pull fails (eg a 404) by showing the error.
Closes: #13
What did you need this functionality for
When using a Rust serverless, it doesn't work & crashes with a mysterious error (Cannot read property 'pipe' of null). However the real issue is that the docker image doesn't exist for rust.
How did you verify your change:
npm compile
npm link
ran in my project, verified that the error message is more clear
What (if anything) would need to be called out in the CHANGELOG for the next release: