-
Notifications
You must be signed in to change notification settings - Fork 4
Update PubMed seed-bank notebook and add batch processing capabilities to almanack
#359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PubMed seed-bank notebook and add batch processing capabilities to almanack
#359
Conversation
d33bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @willdavidson05 ! I left a few comments up for your discretion but overall felt this was looking good.
Once you settle on the code within the data module consider adding tests for the new functions to ensure coverage is retained. Additionally, it looked like there were a few linting checks that still need to be addressed.
src/book/seed-bank/pubmed-github-repositories/almanack_checks.ipynb
Outdated
Show resolved
Hide resolved
almanack
almanackalmanack
gwaybio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and discussion items - Dave, happy for you to make final updating/merging decisions
src/book/seed-bank/pubmed-github-repositories/images/primary-language-counts.png
Show resolved
Hide resolved
...ook/seed-bank/pubmed-github-repositories/images/software-information-entropy-top-5-langs.png
Show resolved
Hide resolved
Co-authored-by: Gregory Way <gregory.way@gmail.com>
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
|
Thank you @gwaybio for your review! Thank you @willdavidson05 for all your work on this too! Merging this in. |
Description
This PR is using the same PubMed Data utilized in the Software Entropy analysis, but applying it to the current Almanack metrics and checks
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.