Skip to content

Conversation

@willdavidson05
Copy link
Member

Description

This PR is using the same PubMed Data utilized in the Software Entropy analysis, but applying it to the current Almanack metrics and checks

What is the nature of your change?

  • Content additions or updates (adds or updates content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own contributions.
  • I have commented my content, particularly in hard-to-understand areas.
  • I have made corresponding changes to related documentation (outside of book content).
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have added tests that prove my additions are effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@willdavidson05 willdavidson05 changed the title Enriching Almanack PubMed data with current Almanack development Enriching PubMed data with current Almanack development Sep 5, 2025
@d33bs d33bs self-requested a review September 5, 2025 21:05
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @willdavidson05 ! I left a few comments up for your discretion but overall felt this was looking good.

Once you settle on the code within the data module consider adding tests for the new functions to ensure coverage is retained. Additionally, it looked like there were a few linting checks that still need to be addressed.

@d33bs d33bs marked this pull request as ready for review December 9, 2025 23:09
@d33bs d33bs requested a review from gwaybio as a code owner December 9, 2025 23:09
@d33bs d33bs changed the title Enriching PubMed data with current Almanack development Rerun PubMed seed-bank notebook and add batch processing capabilities to almanack Dec 9, 2025
@d33bs d33bs changed the title Rerun PubMed seed-bank notebook and add batch processing capabilities to almanack Update PubMed seed-bank notebook and add batch processing capabilities to almanack Dec 9, 2025
Copy link
Member

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and discussion items - Dave, happy for you to make final updating/merging decisions

@d33bs
Copy link
Member

d33bs commented Jan 2, 2026

Thank you @gwaybio for your review! Thank you @willdavidson05 for all your work on this too! Merging this in.

@d33bs d33bs merged commit 58e6383 into software-gardening:main Jan 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants