Skip to content

fix: Remove duplicated native function in ArrayUtils.kt #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chmjkb merged 1 commit into from
Feb 24, 2025
Merged

fix: Remove duplicated native function in ArrayUtils.kt #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions android/src/main/java/com/swmansion/rnexecutorch/models/BaseModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.content.Context
import com.swmansion.rnexecutorch.utils.ETError
import org.pytorch.executorch.EValue
import org.pytorch.executorch.Module
import org.pytorch.executorch.Tensor
import java.net.URL


Expand Down
3 changes: 0 additions & 3 deletions android/src/main/java/com/swmansion/rnexecutorch/utils/ArrayUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ class ArrayUtils {
fun createCharArray(input: ReadableArray): CharArray {
return createTypedArrayFromReadableArray(input) { array, index -> array.getInt(index).toChar() }.toCharArray()
}
fun createByteArray(input: ReadableArray): ByteArray {
return createTypedArrayFromReadableArray(input) { array, index -> array.getInt(index).toByte() }.toByteArray()
}
fun createIntArray(input: ReadableArray): IntArray {
return createTypedArrayFromReadableArray(input) { array, index -> array.getInt(index) }.toIntArray()
}
Expand Down
18 changes: 5 additions & 13 deletions src/SpeechToTextController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ import {
AudioBuffer,
} from 'react-native-audio-api';
import { _SpeechToTextModule } from './native/RnExecutorchModules';
import { EventSubscription, Image } from 'react-native';
import { EventSubscription } from 'react-native';
import { SpeechToText } from './native/RnExecutorchModules';
import * as FileSystem from 'expo-file-system';
import { fetchResource } from './utils/fetchResource';
import decoder from './decoders/WhisperDecodings';

type ModelSource = string | number;
Expand Down Expand Up @@ -50,20 +51,11 @@ export class SpeechToTextController {
encoderSource: ModelSource,
decoderSource: ModelSource
) {
let preprocessorPath = preprocessorSource;
let encoderPath = encoderSource;
let decoderPath = decoderSource;
if (
typeof encoderSource === 'number' &&
typeof decoderSource === 'number' &&
typeof preprocessorSource === 'number'
) {
encoderPath = Image.resolveAssetSource(encoderSource).uri;
decoderPath = Image.resolveAssetSource(decoderSource).uri;
preprocessorPath = Image.resolveAssetSource(preprocessorSource).uri;
}
try {
this.isReady = false;
const preprocessorPath = await fetchResource(preprocessorSource);
const encoderPath = await fetchResource(encoderSource);
const decoderPath = await fetchResource(decoderSource);
await this.nativeModule.loadModule(
preprocessorPath,
encoderPath,
Expand Down