Conversation
|
Also, I am aware that there is significant overlap between this code and object detection. I will try to do something about it, but let's merge this first and let's do it in a separate PR. tests are coming tho |
|
Please rebase and resolve conflicts. Also, when I merged this one: 6acd575, I forgot to update |
msluszniak
left a comment
There was a problem hiding this comment.
The lack of PoseEstimationTask.tsx blocks testing.
09733b7 to
b22762e
Compare
45ca941 to
1dc017c
Compare
| // TODO: maybe create a ContractNotMet error or something like this, this | ||
| // would also need to be applied for other models |
There was a problem hiding this comment.
+1, do we have an issue for that?
There was a problem hiding this comment.
Please change names in demo app (see attached screens).
And I also tested vision camera integration and well. I'm not satisfied in 100% with the results. There are plenty of some random lines that go into the corner, etc. Here is a demo of the problems.
Screen_Recording_20260504_134403_computer-vision.mp4
And please add 'letterboxing' to cspell ignore, there is a warning about this one.
This one is still not addressed. |
|
done cc @msluszniak |
|
Ok, android works perfectly fine, now someone needs to test iOS and I think it's ready to ship :) |
|
I ran iOS app. The model downloads and runs correctly. Both on static images and VC feed. GJ. |


Description
Adds a new pose estimation module to react-native-executorch, mirroring the object detection API surface.
shape — no keypointNames plumbed through the bridge.
the boundary, in both forward and the runOnFrame worklet.
output tensors boxes / scores / keypoints) is documented.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes