refactor: Change model constants to preset objects#477
Merged
Conversation
…mentation to reflect these changes
…dependentCharacters from model in VerticalOCRModule
jakmro
force-pushed
the
@ms/refactor-model-constants
branch
from
a7332ab to
21f9178
Compare
chmjkb
requested changes
Aug 5, 2025
| }) { | ||
| async load( | ||
| model: { | ||
| modelName: AvailableModels; |
Collaborator
There was a problem hiding this comment.
Just a note here: it seems counterintuitive to me why we're doing this modelName thing here, but we don't do it for LLMs or other models.
Contributor
Author
There was a problem hiding this comment.
modelName is required for S2T to select the right strategy
Comment on lines
+33
to
+35
| modelSource: model.modelSource, | ||
| tokenizerSource: model.tokenizerSource, | ||
| tokenizerConfigSource: model.tokenizerConfigSource, |
Collaborator
There was a problem hiding this comment.
Can't we unpack model here?
Comment on lines
+84
to
+88
| _model, | ||
| model.modelName, | ||
| model.encoderSource, | ||
| model.decoderSource, | ||
| model.tokenizerSource, |
Collaborator
There was a problem hiding this comment.
Im not sure if i like the naming here, at a first glance i can't figure out the difference between _model and model, i guess this also applies to other code.
Contributor
Author
There was a problem hiding this comment.
useRef will be used inside this hook, so the variable name will be updated to something like moduleRef
| const DETECTOR_CRAFT_800_MODEL = `${URL_PREFIX}-detector-craft/${VERSION_TAG}/xnnpack/xnnpack_craft_800.pte`; | ||
| const DETECTOR_CRAFT_320_MODEL = `${URL_PREFIX}-detector-craft/${VERSION_TAG}/xnnpack/xnnpack_craft_320.pte`; | ||
|
|
||
| const createHFRecognizerDownloadUrl = (alphabet: string, size: number) => |
Collaborator
There was a problem hiding this comment.
can we narrow down the types here?
Collaborator
There was a problem hiding this comment.
Im changing this in my PR so i guess you can revert it :D
chmjkb
approved these changes
Aug 5, 2025
mkopcins
pushed a commit
that referenced
this pull request
Oct 15, 2025
## Description Change model constants to preset objects ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have updated the documentation accordingly - [x] My changes generate no new warnings --------- Co-authored-by: Mateusz Sluszniak <sluszmat@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change model constants to preset objects
Type of change
Tested on
Checklist