-
Notifications
You must be signed in to change notification settings - Fork 74
feat: Hookless API #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
851b396
Move computer vision hooks to separate directory
2e71bc4
Move hooks to appropriate directories
656a447
Add executorch bindings to hookless api
1f95ad6
Move getTypeIdentifier to common types file
390c5d1
Add LLM hookless api
70c4d99
Rename directory and add exports
2c531ca
Fix lint warnings
41d6b42
Make classes static
031f399
Fix llm hookles api
46e9957
Rename TS interfaces
8a12781
Update docs
8703a56
Add suggested changes
6ecffa5
Fix typing issue
09995c5
Update docs
6f51f6c
Add suggested changes v2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,20 +30,6 @@ try { | |
| } | ||
| ``` | ||
|
|
||
| <details> | ||
| <summary>Type definitions</summary> | ||
|
|
||
| ```typescript | ||
| interface StyleTransferModule { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above |
||
| error: string | null; | ||
| isReady: boolean; | ||
| isGenerating: boolean; | ||
| forward: (input: string) => Promise<string>; | ||
| } | ||
| ``` | ||
|
|
||
| </details> | ||
|
|
||
| ### Arguments | ||
|
|
||
| **`modelSource`** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
src/models/Classification.ts → ...ooks/computer_vision/useClassification.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 7 additions & 9 deletions
16
src/models/ObjectDetection.ts → ...oks/computer_vision/useObjectDetection.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
src/models/StyleTransfer.ts → ...hooks/computer_vision/useStyleTransfer.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 12 additions & 5 deletions
17
src/ETModule.ts → src/hooks/general/useExecutorchModule.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,23 @@ | ||
| export * from './ETModule'; | ||
| export * from './LLM'; | ||
| export * from './constants/modelUrls'; | ||
| export * from './models/Classification'; | ||
| export * from './models/ObjectDetection'; | ||
| export * from './models/StyleTransfer'; | ||
| // hooks | ||
| export * from './hooks/computer_vision/useClassification'; | ||
| export * from './hooks/computer_vision/useObjectDetection'; | ||
| export * from './hooks/computer_vision/useStyleTransfer'; | ||
|
|
||
| export * from './hooks/natural_language_processing/useLLM'; | ||
|
|
||
| export * from './hooks/general/useExecutorchModule'; | ||
|
|
||
| // modules | ||
| export * from './modules/computer_vision/ClassificationModule'; | ||
| export * from './modules/computer_vision/ObjectDetectionModule'; | ||
| export * from './modules/computer_vision/StyleTransferModule'; | ||
|
|
||
| export * from './modules/natural_language_processing/LLMModule'; | ||
|
|
||
| export * from './modules/general/ExecutorchModule'; | ||
|
|
||
| // types | ||
| export * from './types/object_detection'; | ||
|
|
||
| // constants | ||
| export * from './constants/modelUrls'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above