Manual gesture receiving touch events #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing interaction manager
j-piasecki
requested changes
Aug 30, 2022
Comment on lines
+411
to
+413
| if (!event.allTouches || !event.changedTouches || !event.touchEventType) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
This means that mouse and stylus will not send touch events right?
Contributor
Author
There was a problem hiding this comment.
Yes, they don't send touch events by default. We can try mapping pointer events to touch events, but I think that's something that should be done in another PR
j-piasecki
approved these changes
Aug 30, 2022
m-bert
added a commit
that referenced
this pull request
Sep 26, 2022
…#2247) ## Description Until this PR, `PointerTracker` was using `if (pointerId) {...}` to check whether pointerId was provided as argument. Right now, touches are handled by `TouchEvents` and by changes in [this PR](#2188), IDs of touches are mapped to range 0-20. Because of that, when we call `tracker.getLastX(id)`, where `id = 0`, it doesn't return X coordinate of touch with ID 0, but X coordinate of last moved pointer. This makes some handlers malfunction. ## Test plan Tested on example app
54 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces first step to make
ManualGestureHandleravailable on web. Touch events are now being sent to handlers with propneedsPointerData, so it's possible to interact with them. However, there's still no option to manually manage state of this handler, as it requires more changes in state management logic.Test plan
Tested on example app