[Android] Don't remap pointer ids on native handlers #3933
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think it's possible for the
NativeViewGestureHandlerto cause the underlying component to track the same pointer under a different id. When the touch event starts, the root view first passes it through the gesture handler pipeline and then through the native Android pipeline. When a gesture activates, the second path starts being ignored, but since RNGH does pointer id remapping, the same pointer might have had multiple different ids. If the view tries to access the pointer it registered in the second (Android) path, during the RNGH path, the pointer id might not exist.Test plan
TODO