-
Notifications
You must be signed in to change notification settings - Fork 31
Fetchcontent Compatibility #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BorissovAnton
wants to merge
6
commits into
softwareQinc:dev
Choose a base branch
from
BorissovAnton:fetchcontent
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Program ast mod
* PYSTAQ: add predefined opt. levels in python bindings * Add example to compile a simple circuit
* Minor update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Minor update cmake.yml Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Removed triling whitespace in qasm files Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Updated pystaq Changed .h to .hpp Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Added getter method for std_include in Program astnode. (softwareQinc#79) Co-authored-by: matu67 <matteotempo67@gmail.com> Co-authored-by: James Lambert <james.lambert@softwareq.ca> * Added getter method for std_include in Program astnode. (softwareQinc#80) Co-authored-by: matu67 <matteotempo67@gmail.com> Co-authored-by: James Lambert <james.lambert@softwareq.ca> * updated (c) notice * Added CODE_OF_CONDUCT.md Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Updated fmt Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Fix MSVC Windows build Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Updated CHANGES Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * staq_json (softwareQinc#83) * init json.cpp * added pybindings * added pybindings * upd tool * staq_json fix read/write (softwareQinc#84) * fixed declared gates saving to json * staq_json accepts input from stdin now * Minor updates Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Updated Docker config Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> --------- Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> Co-authored-by: matu67 <matteotempo67@gmail.com> Co-authored-by: James Lambert <james.lambert@softwareq.ca> Co-authored-by: Anton Borissov <anton.borissov@softwareq.ca>
…Make configuration: Fixed Path References: - src/tools/CMakeLists.txt:5: Changed CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR for grid_synth.cmake inclusion - CMakeLists.txt:111: Made unit_tests inclusion conditional with relative paths and proper binary directory - CMakeLists.txt:12-13: Updated CMAKE_MODULE_PATH to use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR - CMakeLists.txt:21: Fixed PROJECT_ROOT_DIR definition to use CMAKE_CURRENT_SOURCE_DIR - CMakeLists.txt:148: Fixed installation path for staq_msvc.cmake - unit_tests/CMakeLists.txt:41: Fixed grid_synth.cmake inclusion path Fixed GMP Compilation: - cmake/grid_synth.cmake: Added proper include directory setup for GMP headers - src/tools/CMakeLists.txt: Added target-specific include directories for GMP-dependent tools Added FetchContent Support: - Added detection guard at beginning of main CMakeLists.txt for FetchContent usage Results: - CMake configuration now works correctly with relative paths - All executables build successfully including GMP-dependent tools (grid_synth, qasm_synth, etc.) - Project is now properly relocatable and FetchContent-compatible The project now uses CMAKE_CURRENT_SOURCE_DIR and CMAKE_CURRENT_LIST_DIR instead of CMAKE_SOURCE_DIR, ensuring compatibility with FetchContent usage patterns.
Contributor
Author
|
Comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made staq FetchContent-compatible by fixing absolute path issues in CMake configuration.
Changes